Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Old Event Rates #509

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Mnemotechnician
Copy link
Contributor

@Mnemotechnician Mnemotechnician commented Jul 4, 2024

Description

This restores the basic/survival event rates to how they were before before #486 (however, it keeps the CVars created in it).

  • 5-25 minutes for basic instead of 15-35
  • 4-12 minutes for survival instead of 20-45

Why

The PR made it so that survival rounds actually have less events than extended - that is considering that survival rounds are supposed to be troublesome and filled with events while extended ones are supposed to be a chill alternative.

Other forks don't bother with editing CVars every 5 minutes, so this "opportunity to configure their experience" was never addressed. Based on the feedback I've received from other players, the change was rather negative.

From my personal experience, survival rounds became an extended extended, where during a 2-hour shift you can get a grand total of one power outage and two mice infestations, and nothing else at all.


Changelog

🆑

  • tweak: Events should now occur as frequently as before. Note: server owner can configure the frequency on their server manually.

Signed-off-by: Mnemotechnican <[email protected]>
@github-actions github-actions bot added the Changes: C# Changes any cs files label Jul 4, 2024
@SimpleStation14 SimpleStation14 changed the title Restore old event rates Restore Old Event Rates Jul 4, 2024
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally swapped the initial values in my PR, but survival is supposed to get way more events than extended over the shift, just change its' modifier CVars instead if it doesn't and correct the swap.

@Mnemotechnician
Copy link
Contributor Author

Mnemotechnician commented Jul 4, 2024

The issue is that even if we swap the values, events will still be extremely rare compared to any other fork.

Talking about average of 1 event per 35 minutes in normal gamemodes and 1 in 25 in survival

@Mnemotechnician
Copy link
Contributor Author

I'll add on to my previous statement. I've personally played two survival rounds on deep station with these new default event rates (because no one ever bothers configuring them, default is de-facto the standard). We had zero events. I don't mean it meaphorically, sarcastically, or in any other way. ZERO. Unless your intent was to turn extended into greenshift, and survival into extended, the event rates need to be reverted.

@DangerRevolution
Copy link
Contributor

I don't think having frequent events is a negative for a default; anyone who doesn't like this can change the values, they'll be combing through CVars anyways when setting the server up, but generally the event timings have led to good rounds (just as anecdotal) and anyone wanting slower rounds can slow it down

@Mnemotechnician
Copy link
Contributor Author

I am an active player and I have never heard anyone complain about how there's too many events, ever. However, I did hear others complain that even with the old event rates there were way too little actually dangerous events.

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally believe that it's better to have events be more frequent; and have forks tune it down rather than vice versa. I also believe it lets EE show off some of it's more mechanical changes.

@VMSolidus
Copy link
Member

So since our default is MRP, it really wasn't a terrific idea to have the default for other servers to use be that of HRP style event timers. People had a bit of an odd disconnect with it, expecting the event timers to be relatively consistent, but then had servers with extremely uneventful rounds be the default.

Really, long term I still want to do a Director System, but that'll be on hold until after we get our hands on the Antag Refactor(Having ALL antags being a function you can call is incredibly nice for that.)

@VMSolidus VMSolidus merged commit aaee45a into Simple-Station:master Jul 5, 2024
15 checks passed
SimpleStation14 added a commit that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants